Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: add Dfinity mainnet in testnet chain list #178

Merged
merged 1 commit into from
Oct 21, 2024
Merged

🐛 fix: add Dfinity mainnet in testnet chain list #178

merged 1 commit into from
Oct 21, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Oct 21, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added support for TRC20 tokens in the asset types.
    • Included Dfinity in the list of supported testnet chains.

  • Bug Fixes

    • None identified.

  • Documentation

    • None identified.

  • Refactor

    • None identified.

  • Style

    • None identified.

  • Tests

    • None identified.

  • Chores

    • None identified.

  • Revert

    • None identified.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve two main updates. First, a new static member TRC20 has been added to the ChainAssetType class in basicTypes.ts, initialized with a BigNumber value of 9, expanding the asset type enumeration. Second, the SupportedChainsForTestnet array in chain/index.ts has been modified to include Dfinity, enhancing the list of testnet chains without altering existing functionality in related methods.

Changes

File Path Change Summary
apps/wallet/src/utils/basicTypes.ts Added static member TRC20 to ChainAssetType, initialized with BigNumber(9).
apps/wallet/src/utils/chain/index.ts Added Dfinity to the SupportedChainsForTestnet array. No changes to existing method logic.

Possibly related PRs

  • feat: sign test and chainassetType update #176: The changes in this PR involve modifications to the ChainAssetType class, specifically renaming static properties, which is directly related to the addition of the new static member TRC20 in the main PR. Both PRs deal with updates to asset type classifications within the same class.

Poem

In the wallet where assets play,
A new token joins the fray,
TRC20 hops in with glee,
Dfinity's here, come see!
Chains and tokens, all aligned,
A brighter future, well-defined! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 merged commit ce1581c into main Oct 21, 2024
2 checks passed
@rustin01 rustin01 deleted the fix/minor branch October 21, 2024 03:27
@github-actions GitHub Actions
Copy link

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-qdgbmqx8q-delandlabs-projects.vercel.app

Built with commit 013c9dd.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rustin01